Skip to content

feat: Bump eslint to v10#6552

Draft
davidkna-sap wants to merge 9 commits intomainfrom
davidkna-sap_eslint10
Draft

feat: Bump eslint to v10#6552
davidkna-sap wants to merge 9 commits intomainfrom
davidkna-sap_eslint10

Conversation

@davidkna-sap
Copy link
Copy Markdown
Member

@davidkna-sap davidkna-sap commented Apr 29, 2026

Closes #6547

  • eslint-plugin-import -> eslint-plugin-import-x (faster and supports eslint 10)
  • eslint-plugin-regex (most recent release 4 years ago) -> custom plugin

dependabot Bot and others added 5 commits April 28, 2026 23:04
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.4 to 10.2.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.39.4...v10.2.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 10.2.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Copilot <copilot@github.com>
@davidkna-sap davidkna-sap marked this pull request as ready for review April 29, 2026 08:28
@davidkna-sap davidkna-sap changed the title chore(deps-dev): bump eslint from 9.39.4 to 10.2.1 feat: Bump eslint to v10 Apr 29, 2026
Copy link
Copy Markdown
Contributor

@marikaner marikaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, not sure if it was forgotten or whether we accept removing this rule for the classic config.

Comment on lines -38 to -49
'regex/invalid': [
'error',
[
{
id: 'regexLowerCaseInternal',
// eslint-disable-next-line regex/invalid
regex: '\\@Internal',
// eslint-disable-next-line regex/invalid
message: 'You are not allowed to use @Internal. Please use @internal.'
}
]
],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q/req] There is no replacement for this one?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's limited to the flat configuration now, I will recheck if I can preserve compatibility.

This comment was marked as outdated.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find an external replacement, but the rule is still present in both the project's local and the shared flat eslint configurations.

* origin/main: (26 commits)
  chore: Resolve audit warnings (#6557)
  chore: Fix windows tests (#6568)
  chore(deps-dev): bump turbo from 2.9.7 to 2.9.8 (#6574)
  chore(deps): bump axios from 1.15.2 to 1.16.0 (#6571)
  chore(deps-dev): bump pm2 from 6.0.14 to 7.0.1 (#6572)
  chore(deps): bump bignumber.js from 11.1.0 to 11.1.1 (#6570)
  chore(deps-dev): bump globals from 17.5.0 to 17.6.0 (#6567)
  chore(deps-dev): bump turbo from 2.9.6 to 2.9.7 (#6566)
  chore(deps): bump bignumber.js from 11.0.0 to 11.1.0 (#6562)
  chore(deps): bump nock from 14.0.13 to 14.0.14 (#6563)
  chore(deps-dev): bump @cap-js/sqlite from 2.2.1 to 2.4.0 (#6561)
  chore(deps): bump @typescript-eslint/parser from 8.59.0 to 8.59.1 (#6560)
  chore(deps-dev): bump @sap/cds from 9.9.0 to 9.9.1 (#6559)
  chore(deps): bump typescript-eslint from 8.59.0 to 8.59.1 (#6558)
  chore(pnpm): Enable shell-emulator: true (#6545)
  chore(ci/setup): add `skip-build` option (#6556)
  chore(deps): bump @actions/core from 3.0.0 to 3.0.1 (#6538)
  chore(deps): bump @actions/github from 9.1.0 to 9.1.1 (#6555)
  chore(deps): bump memfs from 4.57.1 to 4.57.2 (#6554)
  chore(deps-dev): bump @types/node from 22.19.15 to 22.19.17 (#6553)
  ...
@davidkna-sap davidkna-sap marked this pull request as draft May 8, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants